thermograph/backend/daemon/internal/config/config_test.go

97 lines
2.9 KiB
Go
Raw Normal View History

daemon: move the Discord gateway and scheduler out of the web process into Go web/app.py started two long-lived background jobs under a leader election: the Discord gateway bot and an APScheduler. Both are stateful I/O loops -- reconnect, RESUME, heartbeat, backoff, interval timers -- living inside an async web app that also has to serve requests. This moves them into a single Go binary. Go owns ONLY the stateful I/O. It owns no climate or grading logic: anything needing data calls back into Python over a new internal-only HTTP surface (/internal/discord/grade, /internal/jobs/warm-cities, /internal/jobs/indexnow). Grading depends on polars and the parquet cache; reimplementing it in Go would make the bot's grades drift from the API's, and the slash-command path deliberately shares one grade builder so the two can never disagree. The grade route returns gateway-ready JSON -- including the ephemeral-flag drop that discord_bot.py used to do -- and Go relays those bytes verbatim without parsing the embed. Packaging: the binary is built by a golang:1.26 stage in the backend Dockerfile and shipped in the SAME image, run as a second compose service off the SAME tag. The daemon and backend share the /internal/* contract, so they must never skew versions; one image makes that structural rather than a convention. Its entrypoint bypasses entrypoint.sh -- the backend owns alembic, and two racing migrators is a real hazard. replicas: 1 in the Swarm stack is load-bearing. Discord permits exactly one gateway connection per bot token; the pin replaces core/singleton.claim_leader for this workload. update_config uses order: stop-first, since start-first would briefly run two gateways. autoscale.sh targets ${STACK_NAME}_web only, so it cannot scale this. Security: the internal routes compare the token with hmac.compare_digest and the whole router 404s when THERMOGRAPH_INTERNAL_TOKEN is unset -- fail closed, never default open. Caddy only routes /api/*, /digest and /discord/interactions to the backend, so /internal/* was never publicly reachable; the token is defence in depth. The router mounts before the catch-all frontend proxy so /internal/* cannot fall through to it. The daemon refuses to start without the token. Behaviour preserved from the Python, with the reasoning carried into the Go comments: non-privileged intents (no MESSAGE_CONTENT, so no portal review); fatal close codes 4004/4010-4014 stop rather than loop; the bot-author and self-author mention-loop guard; allowed_mentions locked to {"parse":[], "replied_user":true} so a crafted query cannot turn a reply into an @everyone ping; the first cron tick deferred one full interval rather than firing at boot, since warm-cities already runs at deploy time; and no overlapping warm-cities run, which would double-spend the archive-fetch quota. Two deliberate improvements over the Python. A close intended for RESUME now uses 4000 rather than 1000 -- Discord invalidates a session closed 1000/1001, so the Python's default close silently defeated its own resume. And MESSAGE_CREATE is handled on a bounded worker pool rather than an unbounded thread hand-off, so a flood of mentions cannot spawn unbounded work against the backend. A .dockerignore is added because a disposable backend/.venv was being swallowed by COPY . /app/ and duplicated again by the chown layer, inflating the image to 1.8 GB; it builds at 578 MB. Tests: 29 Go gateway tests covering every behaviour the deleted test_discord_bot.py asserted, plus cron/config/apiclient suites; 10 new Python tests for the internal routes (fail-closed, auth, flag drop, per-job 409 guard). Full suite 359 passed / 7 skipped; go build, vet and test -race clean.
2026-07-23 22:33:11 +00:00
package config
import (
"testing"
"time"
)
// env builds a getenv func over a map, defaulting the two required vars so
// each test only states what it cares about.
func env(overrides map[string]string) func(string) string {
base := map[string]string{
"THERMOGRAPH_INTERNAL_TOKEN": "sekrit",
"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137",
}
for k, v := range overrides {
base[k] = v
}
return func(k string) string { return base[k] }
}
func TestRequiredVarsRefuseToStart(t *testing.T) {
for _, missing := range []string{"THERMOGRAPH_INTERNAL_TOKEN", "THERMOGRAPH_API_BASE_INTERNAL"} {
if _, err := load(env(map[string]string{missing: ""})); err == nil {
t.Errorf("expected error when %s is unset, got nil", missing)
}
}
if cfg, err := load(env(nil)); err != nil || cfg == nil {
t.Fatalf("both required vars set: unexpected error %v", err)
}
}
func TestTruthyParsing(t *testing.T) {
cases := []struct {
flag, token string
want bool
}{
// Must match the Python _TRUTHY set exactly.
{"1", "tok", true},
{"true", "tok", true},
{"TRUE", "tok", true},
{"yes", "tok", true},
{"on", "tok", true},
{" on ", "tok", true}, // whitespace tolerated, like .strip() in Python
{"0", "tok", false},
{"false", "tok", false},
{"", "tok", false},
{"enabled", "tok", false}, // not in the truthy set
// Flag alone is not enough: no token means no gateway.
{"1", "", false},
}
for _, c := range cases {
cfg, err := load(env(map[string]string{
"THERMOGRAPH_DISCORD_BOT": c.flag,
"THERMOGRAPH_DISCORD_BOT_TOKEN": c.token,
}))
if err != nil {
t.Fatalf("flag=%q token=%q: unexpected error %v", c.flag, c.token, err)
}
if cfg.DiscordEnabled != c.want {
t.Errorf("flag=%q token=%q: DiscordEnabled=%v, want %v", c.flag, c.token, cfg.DiscordEnabled, c.want)
}
}
}
func TestIntervalDefaultsAndFallbacks(t *testing.T) {
cases := []struct {
name string
warm, indexnow string
wantWarm time.Duration
wantIndexNow time.Duration
}{
{"unset uses defaults", "", "", 24 * time.Hour, 6 * time.Hour},
{"explicit values win", "12", "3", 12 * time.Hour, 3 * time.Hour},
// Malformed values degrade to the default instead of erroring, like
// the Python int(... or 24) they replace.
{"garbage falls back", "soon", "1.5", 24 * time.Hour, 6 * time.Hour},
{"non-positive falls back", "0", "-2", 24 * time.Hour, 6 * time.Hour},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
cfg, err := load(env(map[string]string{
"THERMOGRAPH_WARM_CITIES_INTERVAL_HOURS": c.warm,
"THERMOGRAPH_INDEXNOW_INTERVAL_HOURS": c.indexnow,
}))
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if cfg.WarmCitiesInterval != c.wantWarm {
t.Errorf("WarmCitiesInterval=%v, want %v", cfg.WarmCitiesInterval, c.wantWarm)
}
if cfg.IndexNowInterval != c.wantIndexNow {
t.Errorf("IndexNowInterval=%v, want %v", cfg.IndexNowInterval, c.wantIndexNow)
}
})
}
}