Jinemi/thermograph
4
0
Fork 0
Code Issues 2 Pull requests 10 Projects Releases Packages Wiki Activity Actions

bookmarks: don't fabricate a local save when the server rejects it

Browse source
This commit is contained in:
emi 2026-07-26 18:48:32 +00:00
parent 1c6ecc2a6f
commit 41cf11afad
1 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
frontend/static/bookmarks.js
View file

@ -97,17 +97,34 @@ async function syncFromServer(preSyncLocal) {
notify(); notify();
} }
/** Save (or re-save with a new label) the given spot. Upserts either way. */ /** Save (or re-save with a new label) the given spot. Upserts either way.
*
* Throws if signed in and the server explicitly rejects the request (e.g. the
* 409 per-user cap, a 422 on bad input) — that is a real failure, not the
* "offline" case below, and must not be papered over with a local-only
* bookmark that doesn't actually exist server-side and would just vanish,
* unexplained, on the next sync. A genuine network failure (no response at
* all) still falls through to the local-only save so the star visibly
* sticks even offline. */
export async function add(lat, lon, label) { export async function add(lat, lon, label) {
const id = cellId(lat, lon); const id = cellId(lat, lon);
if (signedIn) { if (signedIn) {
let res = null;
try { try {
const res = await apiFetch(uv("bookmarks"), { method: "POST", json: { lat, lon, label: label || undefined } }); res = await apiFetch(uv("bookmarks"), { method: "POST", json: { lat, lon, label: label || undefined } });
} catch (e) {
// offline / network failure: fall through to the local-only path below.
}
if (res) {
if (res.ok) { if (res.ok) {
const rows = await fetchServerList(); const rows = await fetchServerList();
if (rows != null) { cache = rows.map(fromServerRow); writeLocal(cache); notify(); return find(lat, lon); } if (rows != null) { cache = rows.map(fromServerRow); writeLocal(cache); notify(); return find(lat, lon); }
} else {
let msg = `Couldn't save this location (${res.status}).`;
try { const d = await res.json(); if (typeof d.detail === "string") msg = d.detail; } catch (e) { /* no body */ }
throw new Error(msg);
} }
} catch (e) { /* fall through so the star still visibly sticks, even offline */ } }
} }
let b = cache.find((x) => cellId(x.lat, x.lon) === id); let b = cache.find((x) => cellId(x.lat, x.lon) === id);
if (b) { if (label) b.label = label; } if (b) { if (label) b.label = label; }