From a5f90ad6e3d4287d92cc11cf0d707b958c7c8b4d Mon Sep 17 00:00:00 2001
From: Emi Griffith <me@emigriffith.dev>
Date: Sun, 19 Jul 2026 21:14:56 -0700
Subject: [PATCH] Fix the footer leaking "wrapper. #}" from a broken Jinja
 comment (#211)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The note explaining the hidden digest form contained a literal "{# … #}" in its
prose. Jinja doesn't nest comments, so the inner "#}" closed the comment early and
the trailing "wrapper. #}" rendered as visible text at the top of every footer.

Reworded the note without comment delimiters. Adds a test asserting no base-
template page's footer contains a stray "{#"/"#}" (fails against the old template).

Claude-Session: https://claude.ai/code/session_013dRZmX9D3JEntfMKWMTWZ8
---
 templates/base.html.j2 |  4 ++--
 tests/test_content.py  | 12 ++++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/templates/base.html.j2 b/templates/base.html.j2
index 452ac99..c5ed3b4 100644
--- a/templates/base.html.j2
+++ b/templates/base.html.j2
@@ -72,8 +72,8 @@
 
   <footer class="site-footer">
     {# The compact digest signup is the site-wide footer pattern, not a
-       homepage-only surface — every page is a possible entry point.
-       Hidden for now; restore by removing the surrounding {# … #} wrapper. #}
+       homepage-only surface: every page is a possible entry point.
+       Hidden for now; restore by uncommenting the form block below. #}
     {#
     <form class="digest-form digest-compact" method="post" action="{{ base }}/digest"
           data-digest aria-labelledby="footer-digest-label">
diff --git a/tests/test_content.py b/tests/test_content.py
index e8421de..f0db506 100644
--- a/tests/test_content.py
+++ b/tests/test_content.py
@@ -197,6 +197,18 @@ def test_hub_glossary_about(client):
     assert client.get(f"{B}/about").status_code == 200
 
 
+def test_footer_has_no_leaked_jinja_comment(client):
+    # A comment whose prose contained a literal "#}" closed early and leaked
+    # "wrapper. #}" into the footer. Guard every base-template page against a
+    # stray Jinja comment delimiter reaching the rendered HTML.
+    import re
+    for path in (f"{B}/about", f"{B}/climate/{SLUG}", f"{B}/climate/{SLUG}/records"):
+        b = client.get(path).text
+        footer = re.search(r"<footer.*?</footer>", b, re.S)
+        assert footer, f"no footer on {path}"
+        assert "#}" not in footer.group(0) and "{#" not in footer.group(0), path
+
+
 def test_title_name_is_short_and_unique():
     # Titles lead with the bare city name so the payload ("… in July") survives
     # SERP truncation — display_name()'s region+country is what pushed it off the