Jinemi/thermograph
4
0
Fork 0
Code Issues 2 Pull requests 4 Projects Releases Packages Wiki Activity Actions

Hide footer email digest signup for now (#194)

Browse source 
* Hide footer email digest signup for now

Comment out the compact digest signup form in the site footer; restore
by removing the surrounding Jinja comment wrapper.

Claude-Session: https://claude.ai/code/session_01XXxmNFy9cZ6Gh8Y9thZn62

* Update digest test for hidden footer form

The footer signup form is now hidden; assert its absence site-wide.
The /digest endpoint stays live and its tests are unchanged.

Claude-Session: https://claude.ai/code/session_01XXxmNFy9cZ6Gh8Y9thZn62
This commit is contained in:
Emi Griffith 2026-07-19 15:26:47 -07:00 committed by GitHub
parent a991676f88
commit c1d9fd4021
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
templates/base.html.j2
View file

@ -65,7 +65,9 @@
<footer class="site-footer"> <footer class="site-footer">
{# The compact digest signup is the site-wide footer pattern, not a {# The compact digest signup is the site-wide footer pattern, not a
homepage-only surface — every page is a possible entry point. #} homepage-only surface — every page is a possible entry point.
Hidden for now; restore by removing the surrounding {# … #} wrapper. #}
{#
<form class="digest-form digest-compact" method="post" action="{{ base }}/digest" <form class="digest-form digest-compact" method="post" action="{{ base }}/digest"
data-digest aria-labelledby="footer-digest-label"> data-digest aria-labelledby="footer-digest-label">
<label id="footer-digest-label" for="footer-digest-email">Your city's weather, graded — monthly</label> <label id="footer-digest-label" for="footer-digest-email">Your city's weather, graded — monthly</label>
@ -77,6 +79,7 @@
<p class="digest-note muted">No spam, no sharing your address, unsubscribe anytime.</p> <p class="digest-note muted">No spam, no sharing your address, unsubscribe anytime.</p>
<p class="digest-status" role="status" aria-live="polite" hidden></p> <p class="digest-status" role="status" aria-live="polite" hidden></p>
</form> </form>
#}
<nav aria-label="Footer"> <nav aria-label="Footer">
<a href="{{ base }}/climate">City climates</a> <a href="{{ base }}/climate">City climates</a>
<a href="{{ base }}/glossary">Weather glossary</a> <a href="{{ base }}/glossary">Weather glossary</a>

9
tests/test_digest.py
View file

@ -112,9 +112,10 @@ def test_signup_records_event(client):
assert sum(sum(days.values()) for days in after.values()) == before_n + 1 assert sum(sum(days.values()) for days in after.values()) == before_n + 1
def test_form_is_on_every_page(client): def test_form_is_hidden_for_now(client):
"""The digest form is the site-wide footer pattern, not homepage-only.""" """The footer digest signup is temporarily hidden (commented out in the
base template). The /digest endpoint stays live; only the UI is pulled.
Restore the form and flip this back to asserting presence."""
for path in ["/", "/about", "/climate", "/privacy", "/glossary"]: for path in ["/", "/about", "/climate", "/privacy", "/glossary"]:
html = client.get(f"{B}{path}").text html = client.get(f"{B}{path}").text
assert "data-digest" in html, path assert "data-digest" not in html, path
assert 'action="/thermograph/digest"' in html, path