Jinemi/thermograph
4
0
Fork 0
Code Issues 2 Pull requests 3 Projects Releases Packages Wiki Activity Actions

fix(frontend): Weekly view must always send an explicit date to /grade #104

Merged
admin_emi merged 4 commits from fix/weekly-utc-today-date into dev 2026-07-26 06:20:20 +00:00
Conversation 0 Commits 4 Files changed 3 +8 -10
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2d45af8d3a - Show all commits

18
frontend/tests/unit/test_app_js_grade_date.py
View file

@ -6,16 +6,14 @@ midnight for any viewer east of UTC. Reported from Kaunas (UTC+3): asking for
the Weekly tab on 7/26 rendered 7/25. the Weekly tab on 7/26 rendered 7/25.
There is no JS/DOM test harness in this repo to drive app.js and assert on the There is no JS/DOM test harness in this repo to drive app.js and assert on the
real fetch() URL it builds: static/package.json declares zero dependencies (no real fetch() URL it builds -- static/package.json declares zero dependencies, so
jest/playwright/node test runner), no such runner is wired into scripts/test.sh there is no jest/playwright/node runner wired into CI, and nothing else covers
or any workflow, and server/**/*_test.go (the Go suite CI actually gates on) static/*.js runtime behavior. So this can't be a behavioral test. What it CAN
covers the Go SSR layer only, never static/*.js's runtime behavior. So this do, hermetically, through the same served-asset route test_pages.py already
can't be a behavioral test. What it CAN do, hermetically, through the same exercises (`GET {B}/app.js`), is treat the real shipped source as data and
served-asset route test_pages.py already exercises (`GET {B}/app.js`), is treat assert the structural property the fix guarantees: runGrade() builds exactly one
the real shipped source as data and assert the structural property the fix grade URL and always includes an explicit `date=`, rather than branching on
guarantees: runGrade() builds exactly one grade URL and always includes an whether the selected date is "today" and omitting it in that case.
explicit `date=`, rather than branching on whether the selected date is "today"
and omitting it in that case.
This fails against the pre-fix source and passes against the fixed source -- This fails against the pre-fix source and passes against the fixed source --
a source guard, not a substitute for a real behavioral test. a source guard, not a substitute for a real behavioral test.