emi
92e74c585a
All checks were successful
Sync infra to hosts / sync-beta (push) Successful in 13s
Sync infra to hosts / sync-prod (push) Successful in 12s
secrets-guard / encrypted (push) Successful in 7s
shell-lint / shellcheck (push) Successful in 8s
Build + push frontend image (Forgejo registry) / build-push (push) Successful in 53s
Deploy frontend to beta VPS / deploy (push) Successful in 1m16s
secrets-guard / encrypted (pull_request) Successful in 5s
shell-lint / shellcheck (pull_request) Successful in 6s
Ports frontend/ (Jinja2/FastAPI, ~1180 LOC) to Go with html/template. No climate math, no DB, no auth -- every route fetches from the backend's /content/* API. Verified with a golden-HTML diff, not just unit tests: both the Python original and the Go rewrite were run against the same committed fixtures and every route compared byte-for-byte, confirmed programmatically. That process caught defects unit tests alone missed, since map[string]any has no compile-time field check: - Render-context keys were snake_case throughout while the templates read PascalCase fields. A missing map key doesn't error, it silently renders empty -- title, meta description, canonical URL, OpenGraph tags, and the homepage's entire ranked list were blank on every page despite every route returning 200. Fixed by renaming every key to match each template's own documented field contract, and passing API structs straight through wherever their fields already matched (removes a whole layer of future drift risk). - Three pages 500'd: ToolHref needed a composed href, not a bare "lat,lon" fragment; the records table needed the raw API struct. - JSON-LD was double-encoded: <script type="application/ld+json"> is JAVASCRIPT context to html/template's escaper regardless of the script's type attribute, so template.HTML gets re-escaped as a quoted JS string. Needed template.JS. The glossary term page's JSON-LD was never built at all -- added. - html/template silently strips literal HTML and JS comments from parsed output (verified in isolation) -- both need a FuncMap function returning template.HTML/template.JS to survive. Packaging: 187MB -> 22.6MB. Two defects caught before reaching a host: the Swarm stack's entrypoint override with no explicit command drops the image's CMD entirely (every deploy would have exited 127), and COPY --chown by name fails under the classic Docker builder on Alpine. Both fixed. go build/vet/test -race clean; docker build passes its embedded test step under both BuildKit and the classic builder; shellcheck 0 findings.
62 lines
2.5 KiB
Go
62 lines
2.5 KiB
Go
package handlers
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"os"
|
|
"path"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// staticCacheControl mirrors app.py's _STATIC_CACHE_CONTROL: static assets
|
|
// aren't content-hashed in their filenames, so this has to stay short — it's
|
|
// a revalidation window, not a long-lived immutable cache. Still saves a full
|
|
// body re-transfer (the ETag/Last-Modified pair otherwise forces a
|
|
// conditional GET on every navigation) for anything fetched again within it.
|
|
// Stamped on every static file response, including 304s.
|
|
const staticCacheControl = "public, max-age=300"
|
|
|
|
// serveStatic is the catch-all under BASE — the Go analogue of app.py's
|
|
// _CachedStaticFiles mount, matching Starlette's StaticFiles semantics rather
|
|
// than http.FileServer's (which would 301 */index.html to the directory and
|
|
// render directory listings; Starlette 404s both —
|
|
// tests/unit/test_pages.py::test_old_static_index_is_gone pins the index.html
|
|
// case, keeping it from lingering as indexable duplicate content behind the
|
|
// server-rendered homepage).
|
|
func (s *Server) serveStatic(w http.ResponseWriter, r *http.Request) {
|
|
rel := strings.TrimPrefix(r.URL.Path, s.base)
|
|
// Trailing-slash paths never name a file; Starlette 404'd them (the
|
|
// mount swallowed everything under BASE, so redirect_slashes never ran
|
|
// for them).
|
|
if strings.HasSuffix(rel, "/") {
|
|
writePlain(w, http.StatusNotFound, "Not Found")
|
|
return
|
|
}
|
|
// Rooted Clean cannot escape the static dir ("/../x" cleans to "/x");
|
|
// the mux has already cleaned the request path, this is belt and braces
|
|
// for handlers invoked directly (the content package's lazy IndexNow
|
|
// route delegates here without re-cleaning).
|
|
rel = path.Clean("/" + strings.TrimPrefix(rel, "/"))
|
|
full := filepath.Join(s.staticDir, filepath.FromSlash(strings.TrimPrefix(rel, "/")))
|
|
|
|
info, err := os.Stat(full)
|
|
if err != nil || info.IsDir() {
|
|
writePlain(w, http.StatusNotFound, "Not Found")
|
|
return
|
|
}
|
|
f, err := os.Open(full)
|
|
if err != nil {
|
|
writePlain(w, http.StatusNotFound, "Not Found")
|
|
return
|
|
}
|
|
defer f.Close()
|
|
|
|
w.Header().Set("Cache-Control", staticCacheControl)
|
|
// Starlette's StaticFiles stamped a stat-derived ETag (mtime+size hash);
|
|
// same recipe here so If-None-Match revalidation keeps costing an empty
|
|
// 304 instead of a body re-transfer. Headers set before ServeContent
|
|
// survive on its 304/206 paths, Cache-Control included.
|
|
w.Header().Set("ETag", fmt.Sprintf("\"%x-%x\"", info.ModTime().UnixNano(), info.Size()))
|
|
http.ServeContent(w, r, info.Name(), info.ModTime(), f)
|
|
}
|