thermograph/backend/daemon/internal/apiclient/client_test.go
emi 2d3f37c474
All checks were successful
Sync infra to hosts / sync-beta (push) Successful in 8s
Sync infra to hosts / sync-prod (push) Successful in 7s
secrets-guard / encrypted (push) Successful in 8s
shell-lint / shellcheck (push) Successful in 10s
Build + push backend image (Forgejo registry) / build-push (push) Successful in 1m14s
Deploy backend to beta VPS / deploy (push) Successful in 2m4s
daemon: move the Discord gateway and scheduler out of the web process into Go (#21)
The gateway bot and APScheduler were long-lived stateful I/O loops running
inside the async web app under a leader election. They move into a single Go
binary that owns ONLY that I/O -- websocket, RESUME, heartbeat, backoff, timers.

It owns no grading logic. Anything needing data calls back over a new
internal-only surface (/internal/discord/grade, /internal/jobs/*). Grading
depends on polars and the parquet cache; reimplementing it in Go would let the
bot's grades drift from the API's. The grade route returns gateway-ready JSON
and Go relays the bytes verbatim.

The binary ships in the backend image and runs as a second compose service off
the same tag, so the two ends of the /internal/* contract can never skew.
deploy.sh rolls daemon alongside backend -- without that the service would never
be created, since a single-service deploy uses --no-deps. It also probes the
image first and skips the daemon when rolling a tag that predates the binary:
infra tracks main while image tags are env-staged, so a host can legitimately be
asked to roll an older backend image, and creating the service anyway would
leave a container crash-looping on a missing binary.

replicas: 1 with order: stop-first replaces the leader election -- Discord
permits one gateway connection per bot token.

THERMOGRAPH_INTERNAL_TOKEN is optional: both ends derive it from
THERMOGRAPH_AUTH_SECRET via HMAC under a domain-separation label, so this needs
no new vault entry. The derivation is pinned to a shared cross-language test
vector asserted on both sides, so drift fails CI instead of 401ing every call.
Fail closed when neither secret is set.

Improvements over the Python: a close intended for RESUME uses 4000 rather than
1000 (Discord invalidates a session closed 1000, so the old default defeated its
own resume); MESSAGE_CREATE runs on a bounded worker pool; and a malformed HELLO
returns an error rather than a clean reconnect, which would otherwise reset
backoff and hot-loop against the gateway.

365 Python tests pass; Go build/vet/test -race clean; shellcheck 0 findings.
2026-07-23 22:49:54 +00:00

124 lines
3.7 KiB
Go

package apiclient
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
)
func TestGradeHappyPathRelaysBodyVerbatim(t *testing.T) {
// Deliberately odd formatting/key order: Grade must hand back the exact
// bytes, never a re-marshalled reshaping of them.
const body = `{ "content":null, "embeds": [ {"title":"Phoenix"} ] }`
var gotPath, gotToken, gotQuery string
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
gotPath = r.URL.Path
gotToken = r.Header.Get("X-Thermograph-Internal-Token")
var req map[string]string
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
t.Errorf("decode request: %v", err)
}
gotQuery = req["query"]
w.Header().Set("Content-Type", "application/json")
if _, err := w.Write([]byte(body)); err != nil {
t.Errorf("write response: %v", err)
}
}))
defer srv.Close()
c := New(srv.URL, "tok123")
raw, err := c.Grade(context.Background(), "phoenix")
if err != nil {
t.Fatalf("Grade: %v", err)
}
if string(raw) != body {
t.Errorf("body not relayed verbatim:\n got %q\nwant %q", raw, body)
}
if gotPath != "/internal/discord/grade" {
t.Errorf("path = %q", gotPath)
}
if gotToken != "tok123" {
t.Errorf("token header = %q, want %q", gotToken, "tok123")
}
if gotQuery != "phoenix" {
t.Errorf("query = %q", gotQuery)
}
}
func TestJobsSendTokenAndHitRightPaths(t *testing.T) {
paths := map[string]bool{}
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPost {
t.Errorf("method = %s, want POST", r.Method)
}
if r.Header.Get("X-Thermograph-Internal-Token") != "tok" {
t.Errorf("missing/wrong token header on %s", r.URL.Path)
}
paths[r.URL.Path] = true
if _, err := w.Write([]byte(`{"ok":true}`)); err != nil {
t.Errorf("write response: %v", err)
}
}))
defer srv.Close()
c := New(srv.URL+"/", "tok") // trailing slash must not produce "//internal"
if err := c.WarmCities(context.Background()); err != nil {
t.Fatalf("WarmCities: %v", err)
}
if err := c.IndexNow(context.Background()); err != nil {
t.Fatalf("IndexNow: %v", err)
}
for _, p := range []string{"/internal/jobs/warm-cities", "/internal/jobs/indexnow"} {
if !paths[p] {
t.Errorf("path %s was never hit (saw %v)", p, paths)
}
}
}
func TestNon2xxReturnsStatusAndTruncatedBody(t *testing.T) {
long := strings.Repeat("x", 2000)
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
http.Error(w, long, http.StatusBadGateway)
}))
defer srv.Close()
c := New(srv.URL, "tok")
_, err := c.Grade(context.Background(), "phoenix")
if err == nil {
t.Fatal("expected error on 502, got nil")
}
msg := err.Error()
if !strings.Contains(msg, "502") {
t.Errorf("error should include status, got: %s", msg)
}
if !strings.Contains(msg, "truncated") {
t.Errorf("error should mark truncation, got %d chars: %.100s...", len(msg), msg)
}
if len(msg) > 1000 {
t.Errorf("error message not truncated: %d chars", len(msg))
}
}
func TestContextCancellation(t *testing.T) {
block := make(chan struct{})
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
<-block // hold the request open until the test ends
}))
defer srv.Close()
defer close(block)
c := New(srv.URL, "tok")
ctx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
defer cancel()
_, err := c.Grade(ctx, "phoenix")
if err == nil {
t.Fatal("expected error from cancelled context, got nil")
}
if !strings.Contains(err.Error(), "deadline") && !strings.Contains(err.Error(), "cancel") {
t.Errorf("expected a context-shaped error, got: %v", err)
}
}