emi
2d3f37c474
All checks were successful
Sync infra to hosts / sync-beta (push) Successful in 8s
Sync infra to hosts / sync-prod (push) Successful in 7s
secrets-guard / encrypted (push) Successful in 8s
shell-lint / shellcheck (push) Successful in 10s
Build + push backend image (Forgejo registry) / build-push (push) Successful in 1m14s
Deploy backend to beta VPS / deploy (push) Successful in 2m4s
The gateway bot and APScheduler were long-lived stateful I/O loops running inside the async web app under a leader election. They move into a single Go binary that owns ONLY that I/O -- websocket, RESUME, heartbeat, backoff, timers. It owns no grading logic. Anything needing data calls back over a new internal-only surface (/internal/discord/grade, /internal/jobs/*). Grading depends on polars and the parquet cache; reimplementing it in Go would let the bot's grades drift from the API's. The grade route returns gateway-ready JSON and Go relays the bytes verbatim. The binary ships in the backend image and runs as a second compose service off the same tag, so the two ends of the /internal/* contract can never skew. deploy.sh rolls daemon alongside backend -- without that the service would never be created, since a single-service deploy uses --no-deps. It also probes the image first and skips the daemon when rolling a tag that predates the binary: infra tracks main while image tags are env-staged, so a host can legitimately be asked to roll an older backend image, and creating the service anyway would leave a container crash-looping on a missing binary. replicas: 1 with order: stop-first replaces the leader election -- Discord permits one gateway connection per bot token. THERMOGRAPH_INTERNAL_TOKEN is optional: both ends derive it from THERMOGRAPH_AUTH_SECRET via HMAC under a domain-separation label, so this needs no new vault entry. The derivation is pinned to a shared cross-language test vector asserted on both sides, so drift fails CI instead of 401ing every call. Fail closed when neither secret is set. Improvements over the Python: a close intended for RESUME uses 4000 rather than 1000 (Discord invalidates a session closed 1000, so the old default defeated its own resume); MESSAGE_CREATE runs on a bounded worker pool; and a malformed HELLO returns an error rather than a clean reconnect, which would otherwise reset backoff and hot-loop against the gateway. 365 Python tests pass; Go build/vet/test -race clean; shellcheck 0 findings.
66 lines
2.6 KiB
Go
66 lines
2.6 KiB
Go
package config
|
|
|
|
import "testing"
|
|
|
|
// CROSS-LANGUAGE CONTRACT. The daemon and the web app must derive byte-identical
|
|
// tokens from the same THERMOGRAPH_AUTH_SECRET, or every callback 401s -- and it
|
|
// would surface as an auth error, which reads like a bug rather than like the
|
|
// configuration drift it actually is. The same vector is asserted on the Python
|
|
// side in backend/tests/api/test_internal_routes.py::test_derived_token_matches_go.
|
|
// If deriveLabel or the construction changes, BOTH must change together.
|
|
const (
|
|
sharedVectorSecret = "test-auth-secret"
|
|
sharedVectorToken = "4c3830b2158941ff52720d198b65f7924372a3a482b8da52540a4d9be38247ea"
|
|
)
|
|
|
|
func TestDeriveInternalTokenMatchesPython(t *testing.T) {
|
|
if got := deriveInternalToken(sharedVectorSecret); got != sharedVectorToken {
|
|
t.Fatalf("deriveInternalToken(%q) = %q; want %q (must match internal_routes.py)",
|
|
sharedVectorSecret, got, sharedVectorToken)
|
|
}
|
|
}
|
|
|
|
// An empty secret must yield nothing rather than some fixed "empty HMAC" value:
|
|
// the caller turns "" into a refusal to start, and inventing a token here would
|
|
// let the daemon run against a web app that computed a different one.
|
|
func TestDeriveInternalTokenEmptySecretYieldsNothing(t *testing.T) {
|
|
if got := deriveInternalToken(""); got != "" {
|
|
t.Fatalf("deriveInternalToken(%q) = %q; want empty so Load refuses to start", "", got)
|
|
}
|
|
}
|
|
|
|
func TestLoadPrefersExplicitTokenOverDerived(t *testing.T) {
|
|
env := map[string]string{
|
|
"THERMOGRAPH_INTERNAL_TOKEN": "explicit-wins",
|
|
"THERMOGRAPH_AUTH_SECRET": sharedVectorSecret,
|
|
"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137",
|
|
}
|
|
cfg, err := load(func(k string) string { return env[k] })
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
if cfg.InternalToken != "explicit-wins" {
|
|
t.Fatalf("InternalToken = %q; an explicit env var must win over derivation", cfg.InternalToken)
|
|
}
|
|
}
|
|
|
|
func TestLoadDerivesTokenWhenOnlyAuthSecretIsSet(t *testing.T) {
|
|
env := map[string]string{
|
|
"THERMOGRAPH_AUTH_SECRET": sharedVectorSecret,
|
|
"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137",
|
|
}
|
|
cfg, err := load(func(k string) string { return env[k] })
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
if cfg.InternalToken != sharedVectorToken {
|
|
t.Fatalf("InternalToken = %q; want the derived %q", cfg.InternalToken, sharedVectorToken)
|
|
}
|
|
}
|
|
|
|
func TestLoadRefusesWhenNeitherTokenNorAuthSecretIsSet(t *testing.T) {
|
|
env := map[string]string{"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137"}
|
|
if _, err := load(func(k string) string { return env[k] }); err == nil {
|
|
t.Fatal("load succeeded with no token and no auth secret; it must refuse to start")
|
|
}
|
|
}
|