emi
92e74c585a
All checks were successful
Sync infra to hosts / sync-beta (push) Successful in 13s
Sync infra to hosts / sync-prod (push) Successful in 12s
secrets-guard / encrypted (push) Successful in 7s
shell-lint / shellcheck (push) Successful in 8s
Build + push frontend image (Forgejo registry) / build-push (push) Successful in 53s
Deploy frontend to beta VPS / deploy (push) Successful in 1m16s
secrets-guard / encrypted (pull_request) Successful in 5s
shell-lint / shellcheck (pull_request) Successful in 6s
Ports frontend/ (Jinja2/FastAPI, ~1180 LOC) to Go with html/template. No climate math, no DB, no auth -- every route fetches from the backend's /content/* API. Verified with a golden-HTML diff, not just unit tests: both the Python original and the Go rewrite were run against the same committed fixtures and every route compared byte-for-byte, confirmed programmatically. That process caught defects unit tests alone missed, since map[string]any has no compile-time field check: - Render-context keys were snake_case throughout while the templates read PascalCase fields. A missing map key doesn't error, it silently renders empty -- title, meta description, canonical URL, OpenGraph tags, and the homepage's entire ranked list were blank on every page despite every route returning 200. Fixed by renaming every key to match each template's own documented field contract, and passing API structs straight through wherever their fields already matched (removes a whole layer of future drift risk). - Three pages 500'd: ToolHref needed a composed href, not a bare "lat,lon" fragment; the records table needed the raw API struct. - JSON-LD was double-encoded: <script type="application/ld+json"> is JAVASCRIPT context to html/template's escaper regardless of the script's type attribute, so template.HTML gets re-escaped as a quoted JS string. Needed template.JS. The glossary term page's JSON-LD was never built at all -- added. - html/template silently strips literal HTML and JS comments from parsed output (verified in isolation) -- both need a FuncMap function returning template.HTML/template.JS to survive. Packaging: 187MB -> 22.6MB. Two defects caught before reaching a host: the Swarm stack's entrypoint override with no explicit command drops the image's CMD entirely (every deploy would have exited 127), and COPY --chown by name fails under the classic Docker builder on Alpine. Both fixed. go build/vet/test -race clean; docker build passes its embedded test step under both BuildKit and the classic builder; shellcheck 0 findings.
102 lines
3.2 KiB
Go
102 lines
3.2 KiB
Go
package render
|
|
|
|
import (
|
|
"html/template"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
// stubFuncMap satisfies every function name the embedded templates reference
|
|
// (see New's doc comment for the full list) with the minimum needed to parse.
|
|
// The real implementations live in package content (funcmap.go), which itself
|
|
// imports render — so render's own test cannot import content without a
|
|
// cycle, and stands up its own stand-in instead. This only proves the
|
|
// template set PARSES against the real function names; content_test.go (via
|
|
// content.FuncMap) is what proves they render correctly.
|
|
func stubFuncMap() template.FuncMap {
|
|
return template.FuncMap{
|
|
"temp": func(unit, f any) template.HTML { return "" },
|
|
"temp_bare": func(unit, f any) template.HTML { return "" },
|
|
"temp_class": func(f any) string { return "" },
|
|
"ordinal": func(pct any) string { return "" },
|
|
"head_verify": func() template.HTML { return "" },
|
|
"tojson": func(v any) (template.HTML, error) { return "", nil },
|
|
"comment": func(s string) template.HTML { return "" },
|
|
"jscomment": func(s string) template.JS { return "" },
|
|
}
|
|
}
|
|
|
|
func TestETagFormat(t *testing.T) {
|
|
// Same construction as the Python: W/"sha1(body)[:20]".
|
|
// sha1("hello") = aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d
|
|
got := ETag([]byte("hello"))
|
|
want := `W/"aaf4c61ddcc5e8a2dabe"`
|
|
if got != want {
|
|
t.Errorf("ETag = %s, want %s", got, want)
|
|
}
|
|
}
|
|
|
|
func TestNotModifiedAnySplitsOnCommas(t *testing.T) {
|
|
etag := `W/"abc"`
|
|
if !NotModifiedAny(`W/"zzz", W/"abc"`, etag) {
|
|
t.Error("comma-separated candidate list should match")
|
|
}
|
|
if !NotModifiedAny(`W/"abc"`, etag) {
|
|
t.Error("single candidate should match")
|
|
}
|
|
if NotModifiedAny("", etag) {
|
|
t.Error("empty header must not match")
|
|
}
|
|
if NotModifiedAny(`W/"zzz"`, etag) {
|
|
t.Error("non-matching header must not match")
|
|
}
|
|
}
|
|
|
|
func TestNotModifiedExact(t *testing.T) {
|
|
etag := `W/"abc"`
|
|
if !NotModifiedExact(`W/"abc"`, etag) {
|
|
t.Error("exact match should match")
|
|
}
|
|
// app.py's _page compared the raw header — a comma list is NOT split there.
|
|
if NotModifiedExact(`W/"zzz", W/"abc"`, etag) {
|
|
t.Error("exact comparison must not split on commas")
|
|
}
|
|
}
|
|
|
|
func TestWriteHTML(t *testing.T) {
|
|
body := []byte("<html>x</html>")
|
|
etag := ETag(body)
|
|
|
|
rec := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", "/", nil)
|
|
WriteHTML(rec, req, body)
|
|
if rec.Code != 200 || rec.Body.String() != string(body) {
|
|
t.Errorf("fresh GET: code=%d body=%q", rec.Code, rec.Body.String())
|
|
}
|
|
if got := rec.Header().Get("Content-Type"); got != "text/html; charset=utf-8" {
|
|
t.Errorf("Content-Type = %q", got)
|
|
}
|
|
if got := rec.Header().Get("ETag"); got != etag {
|
|
t.Errorf("ETag header = %q, want %q", got, etag)
|
|
}
|
|
|
|
rec = httptest.NewRecorder()
|
|
req = httptest.NewRequest("GET", "/", nil)
|
|
req.Header.Set("If-None-Match", etag)
|
|
WriteHTML(rec, req, body)
|
|
if rec.Code != 304 {
|
|
t.Errorf("conditional GET: code = %d, want 304", rec.Code)
|
|
}
|
|
if rec.Body.Len() != 0 {
|
|
t.Error("304 must have an empty body")
|
|
}
|
|
if got := rec.Header().Get("ETag"); got != etag {
|
|
t.Errorf("304 must still carry the ETag, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestEngineParsesEmbeddedTemplates(t *testing.T) {
|
|
if _, err := New(stubFuncMap()); err != nil {
|
|
t.Fatalf("New: %v", err)
|
|
}
|
|
}
|