All checks were successful
PR build (required check) / changes (pull_request) Successful in 6s
secrets-guard / encrypted (pull_request) Successful in 7s
PR build (required check) / build-backend (pull_request) Has been skipped
shell-lint / shellcheck (pull_request) Successful in 7s
PR build (required check) / validate-observability (pull_request) Has been skipped
PR build (required check) / build-frontend (pull_request) Successful in 1m0s
PR build (required check) / gate (pull_request) Successful in 2s
Ports frontend/ (Jinja2/FastAPI, ~1180 LOC) to Go with html/template. No climate math, no DB, no auth here -- every route fetches from the backend's /content/* API, so this is I/O-bound glue with no hard-porting wall; the risk was always in reproducing the rendering exactly, not the language. Verified with a golden-HTML diff, not just unit tests: both the Python original and the Go rewrite were run against the same committed fixtures (frontend/tests/fixtures/) and every one of the 11 routes compared byte-for-byte. The only surviving differences after that process are insignificant inter-tag whitespace and one attribute where Go's stricter escaper HTML-encodes an apostrophe Jinja left literal (functionally identical in every browser) -- confirmed programmatically by normalizing whitespace and unescaping before diffing, not by eyeballing. That process caught defects unit tests alone would have missed, because map[string]any has no compile-time field check: - Render-context keys were snake_case throughout (content.py's Jinja convention, ported verbatim) while the templates -- written independently -- read PascalCase fields. A missing map key doesn't error in html/template, it silently renders empty, so this was invisible in every status code and every "it built" signal: title, meta description, canonical URL, OpenGraph tags, the homepage's entire ranked list, and the brand-tag/nav-active state were all blank across every page. Fixed by renaming every key to match each template's own header comment (the authoritative per-page field contract) and, where an API struct's exported fields already matched what a template needed (contentapi.CityInfo, Crumb, HomeRanked, HubCountry, ...), passing the struct straight through instead of hand-rewrapping it in a map -- removes a whole layer of future drift risk, not just this instance of it. - Three pages 500'd outright: `.ToolHref` needed a fully-composed href string, not the bare "lat,lon" fragment the handlers were building; the all-time-records table needed the raw contentapi.AllTimeRecords struct, not a re-wrapped map. - JSON-LD was being double-encoded: `<script type="application/ld+json">` is JAVASCRIPT context to html/template's contextual escaper regardless of the script's `type` attribute, so a template.HTML-typed value placed there gets re-escaped as a quoted JS string instead of emitted raw -- the entire structured-data payload shipped as a JSON string containing JSON, which no crawler would parse as the intended object. Needed template.JS instead, the type that actually means "trusted JS source." The glossary term page's JSON-LD was simply never built at all (the Jinja original assembled it inline in the template rather than through content.py's context dict, and that got lost in translation) -- added. - html/template silently strips literal HTML comments AND JavaScript comments from the parsed output (verified in isolation, zero template actions involved) -- confirmed as real engine behavior, not a bug in either port, so both need a FuncMap function returning template.HTML / template.JS respectively to survive parsing rather than a literal `<!-- -->` or `//` in the template source. Packaging: multi-stage Go build, final image alpine (not distroless -- the Swarm stack's env-entrypoint.sh shim needs bash), 187MB -> 22.6MB. Two defects caught before they reached a host: - The Swarm stack overrides `entrypoint:` with no `command:`, which drops the image's own CMD entirely (Docker/Swarm semantics, not merged) -- env-entrypoint.sh then fell through to its hardcoded `exec uvicorn app:app` fallback, which doesn't exist in this image. Every deploy would have exited 127. Fixed with an explicit `command:` on the stack's frontend service, and corrected the shim's stale comment claiming CMD passes through automatically. - `COPY --chown=thermograph` resolves the group by NAME at copy time; Alpine's `adduser -S` with no `-G` doesn't create a same-named group, so the classic (non-BuildKit) Docker builder -- which this CI runner falls back to, since it installs plain `docker.io` with no buildx plugin -- failed outright. Fixed with an explicit group and numeric --chown. Verification: go build/vet/test -race clean across all packages; the Docker image builds and passes its embedded go test step under both BuildKit and the classic builder; shellcheck 0 findings on the one script touched; rebased onto current main (the ERA5 lake stack landed on both main and dev during this work -- confirmed additive, no overlap with frontend/daemon).
80 lines
No EOL
3.3 KiB
Cheetah
80 lines
No EOL
3.3 KiB
Cheetah
{{/* Ported from templates/hub.html.j2. Extra data: .Breadcrumb;
|
|
.NCities/.NCountries int; .Groups — MUST be the ordered
|
|
[]contentapi.HubCountry slice from the hub payload, never a Go map
|
|
(template range over a map sorts keys; Python's dict kept the backend's
|
|
order, and the golden diff would catch the reorder). */}}{{template "base_head_start" .}}{{template "base_head_end" .}}{{template "base_body_start" .}}{{template "breadcrumb" .}}<article class="climate-page">
|
|
<h1>City climates</h1>
|
|
<p class="lede">Average temperatures by month, all-time records, and how today compares, for
|
|
{{.NCities}} cities across {{.NCountries}} countries. Every day is graded against that
|
|
location's own ~45 years of climate history.</p>
|
|
|
|
<div class="hub-search">
|
|
<input type="search" id="hub-q" placeholder="Search a city or country…" autocomplete="off"
|
|
aria-label="Search cities" />
|
|
</div>
|
|
<ul class="hub-results" id="hub-results" hidden></ul>
|
|
|
|
<div id="hub-directory">
|
|
{{range .Groups}} <details class="hub-country">
|
|
<summary>{{.Country}} <span class="hub-count">{{len .Cities}}</span></summary>
|
|
<ul class="city-links">
|
|
{{range .Cities}}<li><a href="{{$.Base}}/climate/{{.Slug}}">{{.Name}}</a></li>{{end}} </ul>
|
|
</details>
|
|
{{end}} </div>
|
|
</article>
|
|
|
|
<script>
|
|
(function () {
|
|
var q = document.getElementById("hub-q");
|
|
var results = document.getElementById("hub-results");
|
|
var directory = document.getElementById("hub-directory");
|
|
if (!q || !results || !directory) return;
|
|
|
|
{{jscomment "Build a flat, alphabetical index from the crawlable directory links."}}
|
|
var index = [];
|
|
directory.querySelectorAll("details.hub-country").forEach(function (d) {
|
|
var country = (d.querySelector("summary").firstChild.textContent || "").trim();
|
|
d.querySelectorAll(".city-links a").forEach(function (a) {
|
|
index.push({ name: a.textContent, country: country, href: a.getAttribute("href") });
|
|
});
|
|
});
|
|
index.sort(function (a, b) {
|
|
return a.name.toLowerCase().localeCompare(b.name.toLowerCase());
|
|
});
|
|
|
|
function esc(s) {
|
|
return s.replace(/[&<>"']/g, function (c) {
|
|
return { "&": "&", "<": "<", ">": ">", '"': """, "'": "'" }[c];
|
|
});
|
|
}
|
|
|
|
function render() {
|
|
var term = q.value.trim().toLowerCase();
|
|
if (!term) {
|
|
results.hidden = true;
|
|
results.innerHTML = "";
|
|
directory.hidden = false;
|
|
return;
|
|
}
|
|
directory.hidden = true;
|
|
results.hidden = false;
|
|
var matches = index.filter(function (e) {
|
|
return e.name.toLowerCase().indexOf(term) >= 0 ||
|
|
e.country.toLowerCase().indexOf(term) >= 0;
|
|
});
|
|
if (!matches.length) {
|
|
results.innerHTML = '<li class="hub-empty muted">No cities match “' + esc(q.value.trim()) + "”.</li>";
|
|
return;
|
|
}
|
|
results.innerHTML = matches.slice(0, 300).map(function (e) {
|
|
return '<li><a href="' + e.href + '">' + esc(e.name) + "</a>" +
|
|
'<span class="hub-r-country">' + esc(e.country) + "</span></li>";
|
|
}).join("") + (matches.length > 300
|
|
? '<li class="hub-empty muted">…and ' + (matches.length - 300) + " more. Keep typing to narrow.</li>"
|
|
: "");
|
|
}
|
|
|
|
q.addEventListener("input", render);
|
|
})();
|
|
</script>
|
|
{{template "base_body_end" .}}{{template "base_scripts_default" .}}{{template "base_tail" .}} |