9eecfc8eef
All checks were successful
PR build (required check) / changes (pull_request) Successful in 6s
secrets-guard / encrypted (pull_request) Successful in 7s
PR build (required check) / build-backend (pull_request) Has been skipped
shell-lint / shellcheck (pull_request) Successful in 7s
PR build (required check) / validate-observability (pull_request) Has been skipped
PR build (required check) / build-frontend (pull_request) Successful in 1m0s
PR build (required check) / gate (pull_request) Successful in 2s
Ports frontend/ (Jinja2/FastAPI, ~1180 LOC) to Go with html/template. No climate math, no DB, no auth here -- every route fetches from the backend's /content/* API, so this is I/O-bound glue with no hard-porting wall; the risk was always in reproducing the rendering exactly, not the language. Verified with a golden-HTML diff, not just unit tests: both the Python original and the Go rewrite were run against the same committed fixtures (frontend/tests/fixtures/) and every one of the 11 routes compared byte-for-byte. The only surviving differences after that process are insignificant inter-tag whitespace and one attribute where Go's stricter escaper HTML-encodes an apostrophe Jinja left literal (functionally identical in every browser) -- confirmed programmatically by normalizing whitespace and unescaping before diffing, not by eyeballing. That process caught defects unit tests alone would have missed, because map[string]any has no compile-time field check: - Render-context keys were snake_case throughout (content.py's Jinja convention, ported verbatim) while the templates -- written independently -- read PascalCase fields. A missing map key doesn't error in html/template, it silently renders empty, so this was invisible in every status code and every "it built" signal: title, meta description, canonical URL, OpenGraph tags, the homepage's entire ranked list, and the brand-tag/nav-active state were all blank across every page. Fixed by renaming every key to match each template's own header comment (the authoritative per-page field contract) and, where an API struct's exported fields already matched what a template needed (contentapi.CityInfo, Crumb, HomeRanked, HubCountry, ...), passing the struct straight through instead of hand-rewrapping it in a map -- removes a whole layer of future drift risk, not just this instance of it. - Three pages 500'd outright: `.ToolHref` needed a fully-composed href string, not the bare "lat,lon" fragment the handlers were building; the all-time-records table needed the raw contentapi.AllTimeRecords struct, not a re-wrapped map. - JSON-LD was being double-encoded: `<script type="application/ld+json">` is JAVASCRIPT context to html/template's contextual escaper regardless of the script's `type` attribute, so a template.HTML-typed value placed there gets re-escaped as a quoted JS string instead of emitted raw -- the entire structured-data payload shipped as a JSON string containing JSON, which no crawler would parse as the intended object. Needed template.JS instead, the type that actually means "trusted JS source." The glossary term page's JSON-LD was simply never built at all (the Jinja original assembled it inline in the template rather than through content.py's context dict, and that got lost in translation) -- added. - html/template silently strips literal HTML comments AND JavaScript comments from the parsed output (verified in isolation, zero template actions involved) -- confirmed as real engine behavior, not a bug in either port, so both need a FuncMap function returning template.HTML / template.JS respectively to survive parsing rather than a literal `<!-- -->` or `//` in the template source. Packaging: multi-stage Go build, final image alpine (not distroless -- the Swarm stack's env-entrypoint.sh shim needs bash), 187MB -> 22.6MB. Two defects caught before they reached a host: - The Swarm stack overrides `entrypoint:` with no `command:`, which drops the image's own CMD entirely (Docker/Swarm semantics, not merged) -- env-entrypoint.sh then fell through to its hardcoded `exec uvicorn app:app` fallback, which doesn't exist in this image. Every deploy would have exited 127. Fixed with an explicit `command:` on the stack's frontend service, and corrected the shim's stale comment claiming CMD passes through automatically. - `COPY --chown=thermograph` resolves the group by NAME at copy time; Alpine's `adduser -S` with no `-G` doesn't create a same-named group, so the classic (non-BuildKit) Docker builder -- which this CI runner falls back to, since it installs plain `docker.io` with no buildx plugin -- failed outright. Fixed with an explicit group and numeric --chown. Verification: go build/vet/test -race clean across all packages; the Docker image builds and passes its embedded go test step under both BuildKit and the classic builder; shellcheck 0 findings on the one script touched; rebased onto current main (the ERA5 lake stack landed on both main and dev during this work -- confirmed additive, no overlap with frontend/daemon).
60 lines
No EOL
3 KiB
Cheetah
60 lines
No EOL
3 KiB
Cheetah
{{/* Ported from templates/month.html.j2. Extra data (all display values are
|
||
pre-formatted by the handler inside the city's unit scope, as in Python):
|
||
.Breadcrumb; .City (needs .Slug); .Display/.Name/.MonthName string;
|
||
.YearRange [2]int; .AvgHigh/.AvgLow template.HTML (temp spans);
|
||
.AvgHighCls/.AvgLowCls string (temp_class names);
|
||
.Stats []{Label string; Value template.HTML};
|
||
.Records []{Label, HighTag, LowTag string; High, Low template.HTML;
|
||
HighDate, LowDate string};
|
||
.ToolHref string — the full "{base}/#{lat:.5f},{lon:.5f}" href, built by
|
||
the handler: composed inline (Jinja's {{ base }}/#{{ tool_hash }}) the
|
||
fragment would hit html/template's urlEscaper and %-escape the comma;
|
||
.CompareURL string; .Prev/.Next {Slug, Name string}. */}}{{template "base_head_start" .}}{{template "base_head_end" .}}{{template "base_body_start" .}}{{template "breadcrumb" .}}
|
||
<article class="climate-page">
|
||
<h1>Weather in {{.Display}} in {{.MonthName}}</h1>
|
||
<p class="lede">In an average {{.MonthName}}, {{.Name}} sees a daily high around
|
||
<b class="t-inline t-{{.AvgHighCls}}">{{.AvgHigh}}</b> and a low around
|
||
<b class="t-inline t-{{.AvgLowCls}}">{{.AvgLow}}</b>, based on
|
||
{{index .YearRange 0}}–{{index .YearRange 1}} of local climate records.</p>
|
||
|
||
<table class="normals-table" style="max-width:520px">
|
||
<tbody>
|
||
{{range .Stats}} <tr><th style="width:55%">{{.Label}}</th><td>{{.Value}}</td></tr>
|
||
{{end}} </tbody>
|
||
</table>
|
||
|
||
{{if .Records}} <h2>{{.MonthName}} records</h2>
|
||
<p class="muted">The most extreme {{.MonthName}} on record for each metric, across
|
||
{{index .YearRange 0}}–{{index .YearRange 1}}. For rainfall, the wettest and driest are by
|
||
total {{.MonthName}} accumulation.</p>
|
||
<div class="records-grid">
|
||
{{range .Records}} <div class="record-card">
|
||
<h3 class="rc-metric">{{.Label}}</h3>
|
||
<div class="rc-row rc-high">
|
||
<span class="rc-tag">{{.HighTag}}</span>
|
||
<span class="rc-val">{{.High}}</span>
|
||
<span class="rc-date">{{.HighDate}}</span>
|
||
</div>
|
||
<div class="rc-row rc-low">
|
||
<span class="rc-tag">{{.LowTag}}</span>
|
||
<span class="rc-val">{{.Low}}</span>
|
||
<span class="rc-date">{{.LowDate}}</span>
|
||
</div>
|
||
</div>
|
||
{{end}} </div>
|
||
{{end}}
|
||
<p><a class="cta" href="{{.ToolHref}}">See {{.Name}}'s live weather grade →</a></p>
|
||
|
||
<div class="travel-note">
|
||
<p>Visiting <b>{{.Name}}</b> in {{.MonthName}}? See how its comfort stacks up against
|
||
where you live.</p>
|
||
<a class="cta" href="{{.CompareURL}}">Compare {{.Name}} with your city →</a>
|
||
</div>
|
||
|
||
<p class="climate-foot muted">
|
||
<a href="{{.Base}}/climate/{{.City.Slug}}/{{.Prev.Slug}}">‹ {{.Prev.Name}}</a> ·
|
||
<a href="{{.Base}}/climate/{{.City.Slug}}">{{.Name}} climate overview</a> ·
|
||
<a href="{{.Base}}/climate/{{.City.Slug}}/{{.Next.Slug}}">{{.Next.Name}} ›</a>
|
||
</p>
|
||
</article>
|
||
{{template "base_body_end" .}}{{template "base_scripts_default" .}}{{template "base_tail" .}} |