adf824b33f
All checks were successful
shell-lint / shellcheck (pull_request) Successful in 8s
PR build (required check) / changes (pull_request) Successful in 6s
secrets-guard / encrypted (pull_request) Successful in 5s
PR build (required check) / build-frontend (pull_request) Has been skipped
PR build (required check) / validate-observability (pull_request) Has been skipped
PR build (required check) / build-backend (pull_request) Successful in 1m33s
PR build (required check) / gate (pull_request) Successful in 3s
web/app.py started two long-lived background jobs under a leader election: the
Discord gateway bot and an APScheduler. Both are stateful I/O loops -- reconnect,
RESUME, heartbeat, backoff, interval timers -- living inside an async web app
that also has to serve requests. This moves them into a single Go binary.
Go owns ONLY the stateful I/O. It owns no climate or grading logic: anything
needing data calls back into Python over a new internal-only HTTP surface
(/internal/discord/grade, /internal/jobs/warm-cities, /internal/jobs/indexnow).
Grading depends on polars and the parquet cache; reimplementing it in Go would
make the bot's grades drift from the API's, and the slash-command path
deliberately shares one grade builder so the two can never disagree. The grade
route returns gateway-ready JSON -- including the ephemeral-flag drop that
discord_bot.py used to do -- and Go relays those bytes verbatim without parsing
the embed.
Packaging: the binary is built by a golang:1.26 stage in the backend Dockerfile
and shipped in the SAME image, run as a second compose service off the SAME tag.
The daemon and backend share the /internal/* contract, so they must never skew
versions; one image makes that structural rather than a convention. Its
entrypoint bypasses entrypoint.sh -- the backend owns alembic, and two racing
migrators is a real hazard.
replicas: 1 in the Swarm stack is load-bearing. Discord permits exactly one
gateway connection per bot token; the pin replaces core/singleton.claim_leader
for this workload. update_config uses order: stop-first, since start-first would
briefly run two gateways. autoscale.sh targets ${STACK_NAME}_web only, so it
cannot scale this.
Security: the internal routes compare the token with hmac.compare_digest and the
whole router 404s when THERMOGRAPH_INTERNAL_TOKEN is unset -- fail closed, never
default open. Caddy only routes /api/*, /digest and /discord/interactions to the
backend, so /internal/* was never publicly reachable; the token is defence in
depth. The router mounts before the catch-all frontend proxy so /internal/*
cannot fall through to it. The daemon refuses to start without the token.
Behaviour preserved from the Python, with the reasoning carried into the Go
comments: non-privileged intents (no MESSAGE_CONTENT, so no portal review);
fatal close codes 4004/4010-4014 stop rather than loop; the bot-author and
self-author mention-loop guard; allowed_mentions locked to {"parse":[],
"replied_user":true} so a crafted query cannot turn a reply into an @everyone
ping; the first cron tick deferred one full interval rather than firing at boot,
since warm-cities already runs at deploy time; and no overlapping warm-cities
run, which would double-spend the archive-fetch quota.
Two deliberate improvements over the Python. A close intended for RESUME now
uses 4000 rather than 1000 -- Discord invalidates a session closed 1000/1001, so
the Python's default close silently defeated its own resume. And MESSAGE_CREATE
is handled on a bounded worker pool rather than an unbounded thread hand-off, so
a flood of mentions cannot spawn unbounded work against the backend.
A .dockerignore is added because a disposable backend/.venv was being swallowed
by COPY . /app/ and duplicated again by the chown layer, inflating the image to
1.8 GB; it builds at 578 MB.
Tests: 29 Go gateway tests covering every behaviour the deleted
test_discord_bot.py asserted, plus cron/config/apiclient suites; 10 new Python
tests for the internal routes (fail-closed, auth, flag drop, per-job 409 guard).
Full suite 359 passed / 7 skipped; go build, vet and test -race clean.
66 lines
2.6 KiB
Go
66 lines
2.6 KiB
Go
package config
|
|
|
|
import "testing"
|
|
|
|
// CROSS-LANGUAGE CONTRACT. The daemon and the web app must derive byte-identical
|
|
// tokens from the same THERMOGRAPH_AUTH_SECRET, or every callback 401s -- and it
|
|
// would surface as an auth error, which reads like a bug rather than like the
|
|
// configuration drift it actually is. The same vector is asserted on the Python
|
|
// side in backend/tests/api/test_internal_routes.py::test_derived_token_matches_go.
|
|
// If deriveLabel or the construction changes, BOTH must change together.
|
|
const (
|
|
sharedVectorSecret = "test-auth-secret"
|
|
sharedVectorToken = "4c3830b2158941ff52720d198b65f7924372a3a482b8da52540a4d9be38247ea"
|
|
)
|
|
|
|
func TestDeriveInternalTokenMatchesPython(t *testing.T) {
|
|
if got := deriveInternalToken(sharedVectorSecret); got != sharedVectorToken {
|
|
t.Fatalf("deriveInternalToken(%q) = %q; want %q (must match internal_routes.py)",
|
|
sharedVectorSecret, got, sharedVectorToken)
|
|
}
|
|
}
|
|
|
|
// An empty secret must yield nothing rather than some fixed "empty HMAC" value:
|
|
// the caller turns "" into a refusal to start, and inventing a token here would
|
|
// let the daemon run against a web app that computed a different one.
|
|
func TestDeriveInternalTokenEmptySecretYieldsNothing(t *testing.T) {
|
|
if got := deriveInternalToken(""); got != "" {
|
|
t.Fatalf("deriveInternalToken(%q) = %q; want empty so Load refuses to start", "", got)
|
|
}
|
|
}
|
|
|
|
func TestLoadPrefersExplicitTokenOverDerived(t *testing.T) {
|
|
env := map[string]string{
|
|
"THERMOGRAPH_INTERNAL_TOKEN": "explicit-wins",
|
|
"THERMOGRAPH_AUTH_SECRET": sharedVectorSecret,
|
|
"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137",
|
|
}
|
|
cfg, err := load(func(k string) string { return env[k] })
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
if cfg.InternalToken != "explicit-wins" {
|
|
t.Fatalf("InternalToken = %q; an explicit env var must win over derivation", cfg.InternalToken)
|
|
}
|
|
}
|
|
|
|
func TestLoadDerivesTokenWhenOnlyAuthSecretIsSet(t *testing.T) {
|
|
env := map[string]string{
|
|
"THERMOGRAPH_AUTH_SECRET": sharedVectorSecret,
|
|
"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137",
|
|
}
|
|
cfg, err := load(func(k string) string { return env[k] })
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
if cfg.InternalToken != sharedVectorToken {
|
|
t.Fatalf("InternalToken = %q; want the derived %q", cfg.InternalToken, sharedVectorToken)
|
|
}
|
|
}
|
|
|
|
func TestLoadRefusesWhenNeitherTokenNorAuthSecretIsSet(t *testing.T) {
|
|
env := map[string]string{"THERMOGRAPH_API_BASE_INTERNAL": "http://web:8137"}
|
|
if _, err := load(func(k string) string { return env[k] }); err == nil {
|
|
t.Fatal("load succeeded with no token and no auth secret; it must refuse to start")
|
|
}
|
|
}
|