b2b56bdc1a
1. CLAUDE.md and README.md described the superseded Python service. Both now describe server/ (Go), say plainly that the Python files at that level are the original the port was made from, and drop CLAUDE.md's claim that `make test-unit` is "the tier CI runs" — CI's only frontend check is the Dockerfile builder stage's gofmt + vet + go test. 2. static/units.js's F_REGIONS was guarded by nothing, despite three source comments claiming "a test asserts all three stay identical": the only check compared the Go set against the backend's Python. TestFCountriesMatchesUnitsJS now diffs the browser copy both directions. That backend cross-check also skips in CI — the image build context is frontend/, so backend/ is unreachable from the builder stage, which is the only place CI runs these tests. static/ IS in the context, so the Dockerfile copies units.js into the builder and the new assertion runs during the image build. Verified by mutating units.js and confirming the build fails. 3. Both docker-compose.test.yml files defaulted to the retired emi/thermograph-backend/app path, and the frontend harness pinned the split-era v0.0.2-split-ci tag. Path corrected in both. Rather than swap one hardcoded pin for another, backend-for-tests.sh now derives the tag from the checkout — sha-<12hex of `git log -1 -- backend/`>, the same domain-keyed rule build-push.yml and deploy.yml use — and compose requires the variable so a stale pin cannot creep back in. Verified: backend 429 passed/8 skipped; frontend go vet clean and all packages ok; frontend image builds; `make backend-up` pulls and serves on the derived tag; shellcheck zero findings across the tree. Unrelated pre-existing issue noted in the docs, not fixed here: `make test-integration` fails 7/16 with 503 against a cold throwaway backend (empty database, nothing warm). Reproduced identically on the old image, so it predates this change. Claude-Session: https://claude.ai/code/session_01AfXqHrxCJLs2D7hpQkiUiJ
47 lines
2.3 KiB
YAML
47 lines
2.3 KiB
YAML
# Test harness: pull the published BACKEND image and run it (+ a throwaway TimescaleDB)
|
|
# so the frontend's integration tests exercise the real HTTP contract instead of
|
|
# importing backend source. Used by scripts/backend-for-tests.sh; not a deploy file.
|
|
# The frontend itself is NOT a service here — the tests run the SSR app in-process
|
|
# (TestClient) with api_client pointed at this backend. DB data is tmpfs (ephemeral).
|
|
services:
|
|
db:
|
|
image: timescale/timescaledb:${TIMESCALEDB_TAG:-latest-pg18}
|
|
environment:
|
|
POSTGRES_USER: thermograph
|
|
POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-testing}
|
|
POSTGRES_DB: thermograph
|
|
tmpfs:
|
|
# pg18 places PGDATA in a version subdir under the mount — mount at /var/lib/postgresql.
|
|
- /var/lib/postgresql
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "pg_isready -U thermograph -d thermograph"]
|
|
interval: 3s
|
|
timeout: 5s
|
|
retries: 20
|
|
|
|
backend:
|
|
# The published backend image is pulled (no local build).
|
|
#
|
|
# No default tag on purpose: scripts/backend-for-tests.sh computes one from
|
|
# THIS checkout -- sha-<12hex of `git log -1 -- backend/`>, the same
|
|
# domain-keyed rule build-push.yml and deploy.yml both use -- so the harness
|
|
# tracks the tree instead of drifting behind a hardcoded pin. (It was pinned
|
|
# to the split-era v0.0.2-split-ci, under the retired
|
|
# emi/thermograph-backend/app path, long after both were superseded.)
|
|
# Override THERMOGRAPH_BACKEND_TEST_TAG to pin a specific build.
|
|
image: ${REGISTRY_HOST:-git.thermograph.org}/${BACKEND_IMAGE_PATH:-emi/thermograph/backend}:${THERMOGRAPH_BACKEND_TEST_TAG:?set it, or run via scripts/backend-for-tests.sh which derives it}
|
|
depends_on:
|
|
db:
|
|
condition: service_healthy
|
|
environment:
|
|
THERMOGRAPH_DATABASE_URL: postgresql+asyncpg://thermograph:${POSTGRES_PASSWORD:-testing}@db:5432/thermograph
|
|
# Required at import; the frontend tests never drive the backend's reverse proxy,
|
|
# so an unreachable placeholder is fine.
|
|
THERMOGRAPH_FRONTEND_BASE_INTERNAL: http://127.0.0.1:1
|
|
THERMOGRAPH_BASE: "/"
|
|
THERMOGRAPH_ENABLE_NOTIFIER: "0"
|
|
PORT: "8137"
|
|
WORKERS: "1"
|
|
ports:
|
|
# Host port defaults to 18137 to avoid a dev server on 8137.
|
|
- "127.0.0.1:${BACKEND_TEST_HOST_PORT:-18137}:8137"
|