Jinemi/thermograph
4
0
Fork 0
Code Issues 2 Pull requests 9 Projects Releases Packages Wiki Activity Actions

frontend: load bookmarks-ui.js from the Go SSR home template too #120

Merged
admin_emi merged 1 commit from fix/bookmarks-go-ssr-script into dev 2026-07-26 18:49:43 +00:00
Conversation 0 Commits 1 Files changed 1 +4 -1
admin_emi commented 2026-07-26 18:48:15 +00:00
Owner
Copy link

The bookmarks feature (#117) added the bookmarks-ui.js module tag to
frontend/templates/home.html.j2 — the Python SSR template — but the home page
is rendered in production by the Go service (frontend/server, embedded
*.tmpl), so nothing on the deployed map page ever loaded the module.

Verified on dev before the fix: /bookmarks.js and /bookmarks-ui.js both
serve 200, /api/v2/bookmarks answers 401 (route live, not 404) and the
bookmark table exists at alembic head 0004_bookmarks — but the rendered
home page referenced only app.js and climate.js. The star toggle, the "Saved"
dropdown and the login import banner were all dead code in the browser.

This ports the one missing line into home.html.tmpl, keeping the two
templates at parity.

The bookmarks feature (#117) added the `bookmarks-ui.js` module tag to `frontend/templates/home.html.j2` — the Python SSR template — but the home page is rendered in production by the Go service (`frontend/server`, embedded `*.tmpl`), so nothing on the deployed map page ever loaded the module. Verified on dev before the fix: `/bookmarks.js` and `/bookmarks-ui.js` both serve 200, `/api/v2/bookmarks` answers 401 (route live, not 404) and the `bookmark` table exists at alembic head `0004_bookmarks` — but the rendered home page referenced only app.js and climate.js. The star toggle, the "Saved" dropdown and the login import banner were all dead code in the browser. This ports the one missing line into `home.html.tmpl`, keeping the two templates at parity.
admin_emi added 1 commit 2026-07-26 18:48:16 +00:00
frontend: load bookmarks-ui.js from the Go SSR home template too
All checks were successful
secrets-guard / encrypted (pull_request) Successful in 5s
Details
PR build (required check) / validate-observability (pull_request) Has been skipped
Details
PR build (required check) / changes (pull_request) Successful in 6s
Details
PR build (required check) / build-backend (pull_request) Has been skipped
Details
shell-lint / shellcheck (pull_request) Successful in 6s
Details
PR build (required check) / build-frontend (pull_request) Successful in 59s
Details
PR build (required check) / gate (pull_request) Successful in 2s
Details
a316adadc4
admin_emi merged commit b57e280ad6 into dev 2026-07-26 18:49:43 +00:00
admin_emi deleted branch fix/bookmarks-go-ssr-script 2026-07-26 18:49:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Jinemi/thermograph#120
No description provided.
Delete branch "fix/bookmarks-go-ssr-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?