promote: dev → main (bookmarks fixes: SSR script tag, phantom save at cap) #123

Merged

admin_emi merged 2 commits from dev into main

2026-07-26 19:17:48 +00:00

admin_emi commented

2026-07-26 19:14:29 +00:00

Owner

Promotion of dev → main. Carries the two fixes that landed after PR #119 was merged.

Commits to carry (2):

b57e280a — #120 frontend: load bookmarks-ui.js from the Go SSR home template too. Without this the bookmarks UI never loaded at all: the script tag had only been added to the old Python Jinja template, but the home page is rendered by the Go SSR service. Verified fixed on the running dev site.
3ec72ca7 — #121 bookmarks: don't fabricate a local save when the server rejects it. add() in bookmarks.js fell back to a local-only save on any non-2xx, so a signed-in user at the 200-bookmark cap saw the star light up "Saved" for a bookmark that was never created, then watched it silently vanish on the next sync.

Verified on dev: home page loads the module, /api/v2/bookmarks live (401 not 404), bookmark table migrated at head 0004_bookmarks.

Not verified: the backend bookmark tests were not executed this run (stale local checkout, pytest blocked) — CI's build is the only evidence there.

Merge method must be merge, not squash — squashing a promotion rewrites history main already shares.

Promotion of dev → main. Carries the two fixes that landed after PR #119 was merged. **Commits to carry (2):** - `b57e280a` — #120 frontend: load `bookmarks-ui.js` from the Go SSR home template too. Without this the bookmarks UI never loaded at all: the script tag had only been added to the old Python Jinja template, but the home page is rendered by the Go SSR service. Verified fixed on the running dev site. - `3ec72ca7` — #121 bookmarks: don't fabricate a local save when the server rejects it. `add()` in `bookmarks.js` fell back to a local-only save on any non-2xx, so a signed-in user at the 200-bookmark cap saw the star light up "Saved" for a bookmark that was never created, then watched it silently vanish on the next sync. **Verified on dev:** home page loads the module, `/api/v2/bookmarks` live (401 not 404), `bookmark` table migrated at head `0004_bookmarks`. **Not verified:** the backend bookmark tests were not executed this run (stale local checkout, pytest blocked) — CI's build is the only evidence there. Merge method must be `merge`, not squash — squashing a promotion rewrites history main already shares.

admin_emi added 2 commits 2026-07-26 19:14:30 +00:00